stanza: respect context in emittest.Sink #32733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect context cancellation to prevent deadlock if the emit callback is invoked during manager shutdown.
|
This is only a test fix, so I think this should be labelled "Skip changelog" - let me know if I should add something. |
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
**Description:** Respect context cancellation in emittest.Sink to prevent deadlock if the emit callback is invoked during manager shutdown. **Link to tracking Issue:** <Issue number if applicable> Related to open-telemetry#32391. Increasing the poll interval in TestCopyTruncate to 5s reliably causes the "timeout: expected: 2700, actual: ..." failure in the linked issue; the test never terminates, and this blocks other tests from running. **Testing:** N/A, fixing test code **Documentation:** N/A
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
**Description:** Respect context cancellation in emittest.Sink to prevent deadlock if the emit callback is invoked during manager shutdown. **Link to tracking Issue:** <Issue number if applicable> Related to open-telemetry#32391. Increasing the poll interval in TestCopyTruncate to 5s reliably causes the "timeout: expected: 2700, actual: ..." failure in the linked issue; the test never terminates, and this blocks other tests from running. **Testing:** N/A, fixing test code **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Respect context cancellation in emittest.Sink to prevent deadlock if the emit callback is invoked during manager shutdown.
Link to tracking Issue:
Related to #32391. Increasing the poll interval in TestCopyTruncate to 5s reliably causes the "timeout: expected: 2700, actual: ..." failure in the linked issue; the test never terminates, and this blocks other tests from running.
Testing:
N/A, fixing test code
Documentation:
N/A