[internal/exp/metrics] Add functions to merge metrics #32794
Conversation
RichieSams
changed the title
|
/label skip-changelog |
|
If someone can apply the |
| @@ -61,3 +65,15 @@ func (m HashMap[T]) Clear() { | |||
| type Evictor interface { | |||
| Evict() identity.Stream | |||
| } | |||
|
|
|||
| type DataPointSlice[DP DataPoint[DP]] interface { | |||
There was a problem hiding this comment.
The changes in this file seemed unrelated to this pr?
There was a problem hiding this comment.
It's used in the datapoint merge function: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32794/files#diff-756513e8ec6edd51e0dc85ef3e3756b9674a2929328395fc63e806e9d052da46R113
I'd also like to migrate processor/intervalprocessor to use this shared definition, instead of having a duplicate interface in multiple places. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/intervalprocessor/internal/metrics/metrics.go
|
Any further questions or concerns? |
|
@RichieSams could you fix the conflicts and failed lint checks? |
|
Are we ok to merge? @jpkrohling we could always move it to pdatautil in a separate pass, if others agree on that point |
|
Ok we're good to merge now. CI is green 🥳 |
|
Bump |
…#32794) **Description:** This will merge the metrics in mdB into mdA, trying to re-use resourceMetrics, scopeMetrics, and metric values as possible. This will be used to help implement the new feature for: open-telemetry#32513 **Link to tracking Issue:** open-telemetry#32513 / open-telemetry#32690 **Testing:** I created a unit test which tests various scenarios of how merge behavior should happen **Documentation:** The exported function is documented using standard golang style. And there are comments inside the code to explain what is going on and why --------- Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Description:
This will merge the metrics in mdB into mdA, trying to re-use resourceMetrics, scopeMetrics, and metric values as possible. This will be used to help implement the new feature for: #32513
Link to tracking Issue: #32513 / #32690
Testing:
I created a unit test which tests various scenarios of how merge behavior should happen
Documentation:
The exported function is documented using standard golang style. And there are comments inside the code to explain what is going on and why