[receiver/vcenter] Adds Initial Support for VM Templates #32831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
May 2, 2024
Cluster vm count metric now does not include templates New default disabled Cluster vm template count metric added VM Template default disabled resource attributes added Fix integration integration test build tag that was accidentally removed
StefanKurek
force-pushed
the
fix/vcenterreceiver_add_vm_templates
branch
from
2258b73
to
fbe3eb7
Compare
crobert-1
approved these changes
May 3, 2024
djaglowski
approved these changes
May 3, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…try#32831) **Description:** <Describe what has changed.> - The Cluster `vcenter.cluster.vm.count` metric now does not include templates in the returned values. - A new (default disabled with warning) Cluster `vcenter.cluster.vm_template.count`metric is added to count only VM templates. - VM Template Resource Attributes `vcenter.vm_template.name` and `vcenter.vm_template.id` have been added (default disabled with warning). If disabled, resources will no longer be created for VM templates. - Trimmed down VM Template metrics to a single expected metric. - Fixed integration test build tag that was accidentally removed in previous PR **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32821 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
vcenter.cluster.vm.countmetric now does not include templates in the returned values.vcenter.cluster.vm_template.countmetric is added to count only VM templates.vcenter.vm_template.nameandvcenter.vm_template.idhave been added (default disabled with warning). If disabled, resources will no longer be created for VM templates.Link to tracking Issue:
#32821
Testing:
Unit/integration tests updated and tested. Local environment tested.
Documentation:
New documentation generated based on the metadata.