deltatocumulative: evict only stale streams #33015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes eviction behavior at limit to only delete streams if they are actually stale. Current behavior just deletes the oldest, which leads to rapid deletion of all streams under heavy load, making this processor unusable.
sh0rez
force-pushed
the
deltatocumulative-evict-only-stale
branch
from
4f85f2a
to
5c92bd3
Compare
RichieSams
reviewed
May 13, 2024
RichieSams
reviewed
May 13, 2024
| @@ -59,5 +59,5 @@ func (m HashMap[T]) Clear() { | |||
| // Evictors remove the "least important" stream based on some strategy such as | |||
| // the oldest, least active, etc. | |||
| type Evictor interface { | |||
| Evict() identity.Stream | |||
| Evict() (identity.Stream, bool) | |||
There was a problem hiding this comment.
Can you document what the returns are
RichieSams
approved these changes
May 15, 2024
jpkrohling
approved these changes
May 16, 2024
| // if not already tracked and no space: try to evict | ||
| if !exist && m.Map.Len() >= m.Max { | ||
| errl := ErrLimit(m.Max) | ||
| gone, ok := m.Evictor.Evict() |
There was a problem hiding this comment.
for a future PR: it would be nice to have an eviction counter, if there isn't one already
|
I'm merging, as @sh0rez is out for a week and I think the comments from this PR can be addressed in a follow-up PR. |
sh0rez
added a commit
to sh0rez/opentelemetry-collector-contrib
that referenced
this pull request
May 27, 2024
jpkrohling
pushed a commit
that referenced
this pull request
May 29, 2024
**Description:** fixes broken check in eviction behavior such that it only evicts actually stale metrics. this was already attempted in #33015, but was insufficient **Testing:** tests were added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes eviction behavior at limit to only delete streams if they are actually stale. Current behavior just deletes the oldest, which leads to rapid deletion of all streams under heavy load, making this processor unusable.
Description:
Link to tracking Issue:
Fixes #33014
Testing:
Documentation: