Update New Relic exporter error conditions. #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-feld
changed the title
a-feld
force-pushed
the
update-newrelic-errors
branch
from
d603bdd
to
d6adcfe
Compare
a-feld
force-pushed
the
update-newrelic-errors
branch
from
d6adcfe
to
16bbd6b
Compare
|
Fixes: #3315 |
|
@alanwest @jack-berg @nrcventura please review. |
nrcventura
approved these changes
May 4, 2021
|
@tigrannajaryan we're all set now 👍 |
bogdandrutu
approved these changes
May 4, 2021
thepeterstone
pushed a commit
to thepeterstone/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2021
* Update New Relic error text to include http response code. * Export cumulative metrics as gauges.
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Remove the proto dependency in goldendataset for traces * revert changelog * update changelog * Update consumer/pdata/common.go Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Fix common.go where there is a missing "}" * Add functions to convert proto keyvalues to AttributeMap * further remove proto dependency * Add PR number to CHANGELOG * update resource_generator_test and resource_to_oc_test * Return nil instead of empty objects for some generator functions. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
* Update New Relic error text to include http response code. * Export cumulative metrics as gauges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR updates the New Relic exporter "error" conditions in a couple of key ways:
Testing: Yes
Fixes: #3315