[connector/spanmetrics] Fix flaky spanmetricsconnector test that relies on timing #33443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the current time from a mockable Clock
swar8080
force-pushed
the
fix-spanmetricsconnector-test-raceconditions_clock
branch
from
1b3b604
to
d1030ef
Compare
t00mas
approved these changes
Jun 12, 2024
|
Failure in |
crobert-1
approved these changes
Jun 21, 2024
pjanotti
approved these changes
Jul 2, 2024
dmitryax
approved these changes
Jul 2, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…es on timing (open-telemetry#33443) **Description:** <Describe what has changed.> Tries fixing some flaky unit tests that relied on `time.Now()` always returning a higher value than the previous call The solution is reading the current time from a `clock.Clock` interface. The test relying on ever-increasing `Now()` values uses a mock that always returns an increasing value. **Link to tracking Issue:** open-telemetry#33438 **Testing:** - Ran the component locally to verify the ticker still flushes after the configured duration passes Closes open-telemetry#33438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tries fixing some flaky unit tests that relied on
time.Now()always returning a higher value than the previous callThe solution is reading the current time from a
clock.Clockinterface. The test relying on ever-increasingNow()values uses a mock that always returns an increasing value.Link to tracking Issue: #33438
Testing:
Closes #33438