[otelarrowreceiver] Ensure consume operations are not canceled at stream EOF #33570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into jmacd/eof_cancels
jmacd
added
the
ready to merge
jmacd
added
ready to merge
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…eam EOF (open-telemetry#33570) **Description:** Fixes a bug in the OTel Arrow receiver. When a stream reaches its end-of-life, the exporter closes the send channel and the receiver's `Recv()` loop receives an EOF error. This was inadvertently canceling a context too soon, such that requests in-flight during EOF would be canceled before finishing. **Link to tracking Issue:** open-telemetry#26491 **Testing:** Several tests cover this scenario, and they had to change for this fix. There is now an extra assertion in the healthy test channel to ensure that consumers never receive data on a canceled context (in testing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a bug in the OTel Arrow receiver. When a stream reaches its end-of-life, the exporter closes the send channel and the receiver's
Recv()loop receives an EOF error. This was inadvertently canceling a context too soon, such that requests in-flight during EOF would be canceled before finishing.Link to tracking Issue: #26491
Testing: Several tests cover this scenario, and they had to change for this fix. There is now an extra assertion in the healthy test channel to ensure that consumers never receive data on a canceled context (in testing).
Documentation: n/a