-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal/otelarrow package for shared code between otelarrow exporter, receiver #33579
Open
jmacd
wants to merge
19
commits into
open-telemetry:main
Choose a base branch
from
jmacd:jmacd/internalarrow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into jmacd/internalarrow
moh-osman3
approved these changes
Jun 17, 2024
lquerel
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tor-contrib into jmacd/internalarrow
jmacd
added a commit
to open-telemetry/otel-arrow
that referenced
this pull request
Jun 21, 2024
Same as open-telemetry/opentelemetry-collector-contrib#33688 but merging this code here will let me create and test a PR in that repository, whereas it will be messy to build off this work in the same repository. I expect this package to be deleted after open-telemetry/opentelemetry-collector-contrib#33688 and open-telemetry/opentelemetry-collector-contrib#33579 merged, as discussed in #225. Part of #227.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The otelarrowexporter and otelarrowreceiver components depend on several libraries in the open-telemetry/otel-arrow repository, which would complicate release management in both repositories. This change eliminates the dependency on
otel-arrow/collector
by moving each of those packages into a subdirectory ofinternal/otelarrow
.Link to tracking Issue: #33567
Testing: This brings new integration tests into this repository for the two otelarrow components.
Documentation: Each of the three non-test packages exposed here has a brief README.md explaining why it exists. Each of these could be useful to non-Arrow components if helpful.