[receiver/datadog] Add initial support for metrics #33631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrieedwards
requested review from
a team,
jpkrohling and
MovieStoreGuy
as code owners
|
Holding off on rebasing until the after the release |
jpkrohling
reviewed
Jun 19, 2024
| @@ -109,3 +133,87 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques | |||
| _, _ = w.Write([]byte("OK")) | |||
|
|
|||
| } | |||
|
|
|||
| // handleV1Series handles the v1 series endpoint https://docs.datadoghq.com/api/latest/metrics/#submit-metrics | |||
| func (ddr *datadogReceiver) handleV1Series(w http.ResponseWriter, req *http.Request) { | |||
There was a problem hiding this comment.
Perhaps not for this PR, but it might be a good idea to split the handlers in their own source file.
There was a problem hiding this comment.
Do you mean something like metrics_receiver.go and traces_receiver.go?
| semconv "go.opentelemetry.io/otel/semconv/v1.25.0" | ||
| ) | ||
|
|
||
| func httpMetrics(meter metric.Meter, next http.Handler) http.Handler { |
There was a problem hiding this comment.
I think we might have a similar metric already being created for all HTTP servers already, perhaps shown only with the telemetry level is set to detailed. If not, we might want to use mdatagen to define the metric.
carrieedwards
force-pushed
the
cedwards/datadog-metrics-receiver
branch
from
eb69c19
to
7f2e37e
Compare
carrieedwards
force-pushed
the
cedwards/datadog-metrics-receiver
branch
from
a005ecc
to
f73d2c9
Compare
| @@ -109,3 +133,87 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques | |||
| _, _ = w.Write([]byte("OK")) | |||
|
|
|||
| } | |||
|
|
|||
| // handleV1Series handles the v1 series endpoint https://docs.datadoghq.com/api/latest/metrics/#submit-metrics | |||
| func (ddr *datadogReceiver) handleV1Series(w http.ResponseWriter, req *http.Request) { | |||
There was a problem hiding this comment.
Do you mean something like metrics_receiver.go and traces_receiver.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the initial structure required to add support for metrics in the Datadog receiver. This is the first of several PRs which will add support for v1 and v2 series endpoints, service checks, as well as sketches.
The full version of the code can be found in the
cedwards/datadog-metrics-receiver-fullbranch, or in Grafana Alloy: https://github.com/grafana/alloy/tree/main/internal/etc/datadogreceiverLink to tracking Issue:
#18278
Testing:
Unit tests have been added. More thorough tests will be included in follow-up PRs as the remaining functionality is added.
Documentation:
Updated README