[exporter/sumologicexporter] Initialized sender to be reused instead of creating it for each batch #33643
Conversation
github-actions
bot
requested review from
aboguszewski-sumo,
kkujawa-sumo,
mat-rumian,
rnishtala-sumo,
sumo-drosiek and
swiatekm-sumo
|
We do not need changelog for this change. It doesn't change neither api nor behavior |
| @@ -146,7 +147,27 @@ func newTracesExporter( | |||
| // start starts the exporter | |||
| func (se *sumologicexporter) start(ctx context.Context, host component.Host) (err error) { | |||
| se.host = host | |||
| return se.configure(ctx) | |||
| err = se.configure(ctx) | |||
There was a problem hiding this comment.
I think we need to recreate the sender inside configure. configure may be called asynchronously as a result of receiving an unauthorized error from the remote, in which case we want to get the data urls again. This used to be done implicitly by creating a new sender, but with this change we need to do so explicitly and handle any resultant concurrency issues.
There was a problem hiding this comment.
makes sense 💪
chan-tim-sumo
force-pushed
the
chan-tim_refactorPushTraces
branch
from
d16cdd2
to
cbb4edd
Compare
seems to have a build error without a changelog 🤔 |
@jpkrohling Could you add label to skip the changelog check please? |
|
hey @songy23 can you take a look at this pr? and if you're able to, can you add label to skip the changelog check? thanks alot! |
|
Looks like you have a changelog already so I don't think or if you prefer to not have the changelog, please remove it from this PR |
Gotcha @songy23 , added it before since build failed without it. But just removed the change log. |
chan-tim-sumo
force-pushed
the
chan-tim_refactorPushTraces
branch
from
62008b0
to
a56937a
Compare
|
hey @dmitryax , can you take a look at this pr too? thanks alot! 💪 |
Description:
Refactored sender to be created once and reused instead of creating a new sender each batch.
Link to tracking Issue:
Testing:
Documentation: