[exporter/datasetexporter] Upgrade to dataset-go v0.19.0 #33675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
|
There is failing check - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9598696641/job/26470817018?pr=33675#step:13:1 However, when I run that command: And based on the Or |
crobert-1
reviewed
Jun 20, 2024
Co-authored-by: Curtis Robert <crobert@splunk.com>
tomaz-s1
reviewed
Jun 21, 2024
| component: datasetexporter | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Upgrade dataset-go to v0.19.0 and fix found issues |
There was a problem hiding this comment.
May want to briefly clarity what those "found issues" were under subtext.
tomaz-s1
approved these changes
Jun 21, 2024
I have added those details. My expectation was, that changelog is meant for users - and they do not care whether integration tests are now running when in the past they have been skipped. |
atoulme
approved these changes
Jun 21, 2024
This file appears to be no longer used. Since it's in an `internal` directory it's not exposed publicly, so I don't believe it needs a changelog. For context, I believe its original use was to be consumed by `cmd/configschema`, which has since been [deleted](open-telemetry#33384). I believe we simply missed this file in the removal process.
…elemetry#33691) The produced metrics are unnecessarily grouped by empty resources. This change removes the excessive grouping to keep only unique resources
This PR attempts to make schemaURL for TransformContexts. **Description:** <Describe what has changed.> Added a breaking change to creation of TransformContext function for logs. Also made changes to all references of the function. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30229 --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
This has been broken for some time as the definition of GOTEST was removed Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…pen-telemetry#33710) A recent issued brought up that the `username` config option is available, but not documented in the README. The `password` option is described in the README, but doesn't include information relevant for Redis >= 6.0. This adds information on both config options. Fixes open-telemetry#33707
…nents (open-telemetry#33695) Adding myself as a codeowner for Windows performance counter and related components per respective call for more volunteers on the respective README files. I have experience with Windows and was a maintainer of the collector some years ago. Per DM I am also removing @djaglowski from `receiver\windowseventlog`, ActiveDirectoryDS, and IIS. cc @alxbl
…etry#33628) **Description:** Labels the `otelarrowexporter` and `otelarrowreceiver` as alpha, adds them to the contribcol. **Link to tracking Issue:** open-telemetry#26491
This updates the code that was using OpenCensus to use mdatagen + otel Fixes open-telemetry#33468 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
The expected and actual errors are misplaced. It makes the test output confusing
**Description:** Optimize statsdreceiver code to reduce heap usage Also reduce failCnt increment to reduce memory footprint in cases of tons of malformed statsd messages **Link to tracking Issue:** <Issue number if applicable> **Testing:** - Tested internally and saw a 17% reduction in object allocation from our workloads (with ~2.5k/s statsd metrics input) mostly from reduction of strings.Split Screenshot is from `go tool pprof -http:8081 -diff_base baseline.heap.gz optimized.heap.gz`  Note: I also saw lots of allocations from attribute.NewSet but idk the best way to go about reducing that. (Screenshot below is from unoptimized statsdreceiver)  I tried changing statsDMetricDescription's attrs field to `map[string]any` in the hopes of using attributes.FromRaw in buildGaugeMetric but it would require replacing statsDMetricDescription as the type of the map key in instruments.gauges, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR is upgrading dataset-go to version v0.19.0 - https://github.com/scalyr/dataset-go/releases/tag/v0.19.0
This PR is also fixing:
Link to tracking Issue: #33498, #32533, #33675
Testing: Unit tests and integration tests.
Documentation:
fixes #32533