Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl]: add IsRootSpan converter #33729

Merged
merged 11 commits into from
Jul 14, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 24, 2024

Description:

Introduced IsRootSpan() converter function which returns true if the span in the corresponding context is root, that means its parent_span_id equals to hexadecimal representation of zero. In all other scenarios function returns false.

Link to tracking Issue: #32918

Testing:

  • unit tests
  • e2e tests

Documentation:

  • README entry

@odubajDT odubajDT changed the title Add isrootspan [pkg/ottl]: add IsRootSpan converter Jun 24, 2024
@odubajDT odubajDT marked this pull request as ready for review June 25, 2024 06:56
@odubajDT odubajDT requested a review from a team as a code owner June 25, 2024 06:56
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs reviewer here. Just a couple suggestions. Thanks!

pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
.chloggen/add-isrootspan.yaml Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_is_root_span_test.go Outdated Show resolved Hide resolved
odubajDT and others added 9 commits July 12, 2024 07:07
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@TylerHelmuth TylerHelmuth merged commit 3c64a31 into open-telemetry:main Jul 14, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 14, 2024
abhishek-at-cloudwerx pushed a commit to Internal-Cloudwerx/opentelemetry-collector-contrib that referenced this pull request Aug 9, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Introduced `IsRootSpan()` converter function which returns `true` if the
span in the corresponding context is root, that means its
`parent_span_id` equals to hexadecimal representation of zero. In all
other scenarios function returns `false`.

**Link to tracking Issue:** open-telemetry#32918

**Testing:** 

- unit tests
- e2e tests

**Documentation:** <Describe the documentation added.>

- README entry

---------

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants