Fix issue #33464 [processor/groupbytrace] migrate from opencensus library #33770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Thanks @honeychaudharyc, please sign the CLA and we can get this reviewed
jpkrohling
reviewed
Jul 3, 2024
|
|
||
| The following telemetry is emitted by this component. | ||
|
|
||
| ### processor_groupbytrace_conf_num_traces |
There was a problem hiding this comment.
I think we have an otelcol_ prefix to this metric today. We need to ensure that we are not introducing a breaking change to users.
There was a problem hiding this comment.
the prometheus exporter configuration prepends that prefix automatically
jpkrohling
approved these changes
Jul 4, 2024
…encensus library This migrates internal metrics from opencensus to mdatagen + otel. Used metadata.Telemetrybuilder and replaced all metrices from metrics file to metadata.yaml file. Updated tests to move from opencensus. Documentation generated by metadata.yaml file
|
Metrics before the change: After the change: |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
Brought back the metric test that was looking at the gauge values using otel instead of opencensus. This should be ready to go now |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the internal metrics from opencensus for the groupbytrace processor to Opentelemetry for metrics, via mdatagen. Used metadata.Telemetrybuilder and replaced all metrices from metrics file to metadata.yaml file. Updated tests to move from opencensus.
Fixes #33464
Testing: Unit tests
Documentation: Documentation generated by metadata.yaml.