Added support for insecure connection with Sentry #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AbhiPrasad please review |
AbhiPrasad
suggested changes
May 26, 2021
|
@AbhiPrasad i can see that the tests failed but clearly not because of the proposed changes. Should I do something about it? |
|
Yeah not sure why the tests are failing. Also, I would rebase on |
AbhiPrasad
approved these changes
May 27, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@bogdandrutu @kbrockhoff What are the next steps? |
bogdandrutu
approved these changes
Jun 10, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
* Added support for insecure connection with Sentry * update README.md * add doc string to Config struct * rename insecure configuration flag * update README.md according to new exporter config * update example according to new exporter config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added an option that disables ssl certificate verification.
If Sentry is deployed in a private cloud and its ssl certificate is not valid (from a global point of view), then traces will simply not be sent. What's especially bad is that it happens quietly. There is no error anywhere in the logs.
Testing:
The package tests have not changed and are running successfully
Documentation:
Updated the readme