K8S: Adding ignored pod names as config parameter #3520
Conversation
|
|
||
| ignored_pod_names: | ||
| - jaeger-agent | ||
| - jaeger-collector |
There was a problem hiding this comment.
Since we already have filter config above, I think adding a more generic exclude would be better than something dedicated to just ignoring pods. May be something like
exclude:
pods:
- jaeger-agent
- jaeger-collectorThere was a problem hiding this comment.
Actually I think the following would be even better as it's more future proof. This can allow us to exclude pods by fields other than name in future if we want.
exclude:
pods:
- name: jaeger-agent
- name: jaeger-collectorThere was a problem hiding this comment.
Sounds good. Made those changes! :)
euniceek
requested review from
alolita,
anuraaga,
arminru and
jrcamp
as code owners
euniceek
force-pushed
the
k8s-config-pod-names
branch
4 times, most recently
from
93003ce
to
f0c8740
Compare
| // Check well known names that should be ignored | ||
| for _, rexp := range podNameIgnorePatterns { | ||
| // Check if user requested the pod to be ignored through configuration | ||
| for _, rexp := range c.Exclude.Regex { |
There was a problem hiding this comment.
If we make the changes suggested below, this should read something like the following:
for _, excludedPod := range c.Exclude.Pods {
if excludedPod.Name.MatchString(pod.Name) {There was a problem hiding this comment.
Thanks for the feedback and help! The requested changes have been made.
euniceek
force-pushed
the
k8s-config-pod-names
branch
from
3b10700
to
58389fb
Compare
euniceek
force-pushed
the
k8s-config-pod-names
branch
from
58389fb
to
1d24125
Compare
|
I am going to add the ready-to-merge label since this looks ready and has three approvals |
mx-psi
added
the
ready to merge
On error pdata.Metrics may not be initialized so guard against it. Update test to return uninitialized object on error.
* Add ignore config parameter * Add ignoredPodNames method * Fix IgnoredPodNames to contain regexp * Fix doc and regexp default * Refactor config entry and WithIgnoredPodNames method * Refactor ignoredPods to exclude * Rename Exclude functions and structs * Refactor Exclude struct
Description:
This PR addresses #1077 by adding a new parameter to the K8S configuration allowing users to define names of pods to ignore while tagging. Previously, the names are hardcoded and noted as TODO.
Testing:
makewas used to test the new implementation and to ensure no other pre-existing functionality was broken.New unit tests were added to ensure that the default
ignored_pod_namesare[jaeger-agent, jaeger-collector]and that users will be able to add additional pod names.