482 add support for taskdefinitionfamily placeholder on log stream name #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hossain-rayhan would you be able to take a look at this? |
|
@anuraaga Could you take another look at this? |
hossain-rayhan
approved these changes
Jun 15, 2021
anuraaga
approved these changes
Jun 15, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
…me (open-telemetry#3755) * 482 add support for taskdefinitionfamily placeholder on log stream name * Issue 482 add unit test for task definition family
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add TaskDefinitionFamily placeholder support for log stream naming in awsemfexporter
Link to tracking Issue:
aws-observability/aws-otel-collector#482
Testing:
Added test case that sets log stream name to {TaskId}-{TaskDefinitionFamily} (as desired in issue 482)
Documentation:
Included TaskDefinitionFamily placeholder usage in README