Fixed filtered attribute translation in the AWS X-Ray exporter. #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this @jefchien. It looks like there is a fundamental problem with the attribute filtering - it should still use attributes, not strings, since XRay supports non-string attributes. We convert here But currently only do so for resources attributes - the same should be done for span attributes. Would you be able to make the change so the attribute filtering happens on attributes instead of string map? |
…y-collector-contrib into 518-non-string-span
|
So, instead of converting the |
…type throughout segment generation. Moved test from http_test.go to segment_test.go
…y-collector-contrib into 518-non-string-span
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
…-telemetry#3757) * Fixed filtered attribute translation in the AWS X-Ray exporter. * Changed AWS X-Ray filtered attributes to maintain the AttributeValue type throughout segment generation. Moved test from http_test.go to segment_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In the AWS X-Ray exporter, non-string attribute values were showing up as empty strings. Imported the
AttributeValueToStringfunction fromprotospan_translation.goand used it to perform the translation.Link to tracking Issue: aws-observability/aws-otel-collector#518
Testing: Tested with
aws-otel-test-framework. AddedTestSpanWithFilteredAttributestest tohttp_test.goto check each of the types.