[exporter/datadog]: ensure top level spans are computed #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
changed the title
mx-psi
reviewed
Jun 15, 2021
mx-psi
added
the
ready to merge
bogdandrutu
approved these changes
Jun 16, 2021
| @@ -37,6 +37,7 @@ func computeAPMStats(tracePayload *pb.TracePayload, pushTime int64) *stats.Paylo | |||
| bucketTS := pushTime - statsBucketDuration | |||
| for _, trace := range tracePayload.Traces { | |||
| spans := getAnalyzedSpans(trace.Spans) | |||
|
|
|||
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A previous PR accidentally dropped top level span computation, (here: 2696783#diff-b98fa670a9a811a13714fe4ce9bb4b3c5c6442c05638eb156a61e5480e8aa8faL82) which has caused an unintended effect of causing a large number of spans to not be retained. This PR reverts that change
Link to tracking Issue:
Testing:
updated unit tests
Documentation: