Datadog update env clobbering behavior #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Jun 22, 2021
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
mx-psi
previously approved these changes
Jun 22, 2021
|
|
@ericmustin see comment above |
|
@mx-psi @bogdandrutu sorry about that, should be good to go now (would love to get this in v0.29.0 if you don't mind) |
mx-psi
approved these changes
Jun 22, 2021
|
@jchengsfx @bogdandrutu it would be great to get this in for v0.29.0 if possible |
mx-psi
added
the
ready to merge
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
#3851) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
* [exporter/datadog]: handle multiple env tag edge case * [exporter/datadog]: fix typos in code comments * Update exporter/datadogexporter/translate_traces_test.go Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> * Update exporter/datadogexporter/translate_traces.go Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> * [exporter/datadog]: linting and formatting Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sometimes users will set both a
deployment.environment(the opentelemetry semantically correct way to define an environment attribute) attribute and anenvattribute (the datadog way to define an environment span tag) on the same application, but they will have different values. This creates a variety of unintended behaviors within the Datadog UI, which correctly usesdeployment.environmentvalues for most critical details, but hardcodes some links to other views using theenvvalue, leading confusing behavior. for the sake of a coherent experience, it makes sense to ensure these span tags are always set to the same value (thedeployment.environment) even if that means clobbering the originalenvvalue.Link to tracking Issue: n/a
Testing: added a unit test
Documentation: adding docs to the Datadog docs/onboarding page encouraging users to rely on the opentelemetry best practice
deployment.environmentonly. cc @mx-psi