Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename DoubleDataPoint to NumberDataPoint #4210

Merged
merged 6 commits into from
Jul 20, 2021
Merged

rename DoubleDataPoint to NumberDataPoint #4210

merged 6 commits into from
Jul 20, 2021

Conversation

codeboten
Copy link
Contributor

Description:
Rename DoubleDataPoint to NumebrDataPoint. Contrib repo update for open-telemetry/opentelemetry-collector#3633

Link to tracking Issue: Part of open-telemetry/opentelemetry-collector#3534

@project-bot project-bot bot added this to In progress in Collector Jul 16, 2021
@codeboten
Copy link
Contributor Author

I see one of the tests failed, not immediately clear to me if it's related to this change or not

     integration_test.go:219: 
        	Error Trace:	integration_test.go:219
        	            				asm_amd64.s:1371
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 4
        	Test:       	TestJMXIntegration/TestJMXReceiverHappyPath
    integration_test.go:176: 
        	Error Trace:	integration_test.go:176
        	Error:      	Condition never satisfied
        	Test:       	TestJMXIntegration/TestJMXReceiverHappyPath
        	Messages:   	metrics not collected:

@codeboten codeboten force-pushed the codeboten/rename-double-data-point branch from a8b3bd7 to 6fe2c83 Compare July 16, 2021 21:06
@codeboten
Copy link
Contributor Author

I see one of the tests failed, not immediately clear to me if it's related to this change or not

     integration_test.go:219: 
        	Error Trace:	integration_test.go:219
        	            				asm_amd64.s:1371
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 4
        	Test:       	TestJMXIntegration/TestJMXReceiverHappyPath
    integration_test.go:176: 
        	Error Trace:	integration_test.go:176
        	Error:      	Condition never satisfied
        	Test:       	TestJMXIntegration/TestJMXReceiverHappyPath
        	Messages:   	metrics not collected:

Turns out the failure was caused by the change to translate IntSum to Sum open-telemetry/opentelemetry-collector#3621

@bogdandrutu
Copy link
Member

Please fix the lint errors

@codeboten
Copy link
Contributor Author

Please fix the lint errors

Addressed the errors, I reverted the prom-counter example back to using v0.20.0 of the otel go SDK, will update that in a separate PR.

@codeboten
Copy link
Contributor Author

Separate PR for the prom counter here #4261

Collector automation moved this from In progress to Reviewer approved Jul 20, 2021
@codeboten codeboten force-pushed the codeboten/rename-double-data-point branch from 98f3962 to 3a58d9f Compare July 20, 2021 17:01
@codeboten codeboten force-pushed the codeboten/rename-double-data-point branch from 3a58d9f to 6f4ea43 Compare July 20, 2021 17:18
@codeboten codeboten force-pushed the codeboten/rename-double-data-point branch from 6f4ea43 to d2c5126 Compare July 20, 2021 17:39
@codeboten codeboten force-pushed the codeboten/rename-double-data-point branch from d2c5126 to 6cd3ecf Compare July 20, 2021 17:41
@bogdandrutu bogdandrutu merged commit deca828 into open-telemetry:main Jul 20, 2021
Collector automation moved this from Reviewer approved to Done Jul 20, 2021
@codeboten codeboten deleted the codeboten/rename-double-data-point branch July 20, 2021 21:23
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
rename DoubleDataPoint to NumberDataPoint (open-telemetry#4210)
bc0b70e 
* rename DoubleDataPoint to NumberDataPoint

* make update-otel

* revert change to tracegen/go.sum

* mod tidy
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
add ExponentialHistogram field to pdata (open-telemetry#4219)
ecd5347 
Adds OTLP v0.11.0 data type ExponentialHistogram to pdata.

**Link to tracking Issue:** Fixes open-telemetry#4210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@anuraaga anuraaga anuraaga approved these changes

@jmacd jmacd jmacd approved these changes

@alolita alolita Awaiting requested review from alolita

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@arminru arminru Awaiting requested review from arminru

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@jrcamp jrcamp Awaiting requested review from jrcamp

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@owais owais Awaiting requested review from owais

@punya punya Awaiting requested review from punya

Assignees

@Aneurysm9 Aneurysm9

Labels
None yet
Projects
No open projects
Collector
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codeboten @bogdandrutu @anuraaga @jmacd @Aneurysm9