observer extension: Add generic endpoint watcher #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuresh4
force-pushed
the
endpoint-watcher
branch
from
e539a95
to
daf3f9c
Compare
jrcamp
reviewed
Jul 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 84.71% 84.80% +0.08%
==========================================
Files 174 176 +2
Lines 9389 9436 +47
==========================================
+ Hits 7954 8002 +48
Misses 1113 1113
+ Partials 322 321 -1
Continue to review full report at Codecov.
|
Merged
jrcamp
reviewed
Jul 13, 2020
jrcamp
approved these changes
Jul 15, 2020
tigrannajaryan
pushed a commit
that referenced
this pull request
Jul 28, 2020
Depends on #427 **Description:** Add host observer to look for listening network endpoints on host **Testing:** Unit tests added. Manually tested with `receivercreator` receiver. **Documentation:** [README.md](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/eabd8d4fe646d7589466c471dc27f96bc0d7c530/extension/observer/hostobserver/README.md).
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add
EndpointsWatcher, a struct with utilities required to poll and track endpoints in a generic manner. It is an implementation ofobserver.Observableand will help in abstracting some logic that's required by poll based observers. This struct is meant to be embedded by observers that listobserver.Endpoint. Will also open a separate PR with changes that make use of this update.The diff also has some minor refactoring.
Testing: Added unit tests.
Documentation: Added inline comments.