Update kubeletstats metrics according to semantic conventions #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update kubeletstats receiver metrics according to open-telemetry/oteps#119 : - Remove "k8s." from container metrics - Change "/" metric delimiter to "." - Change ...network -> ...network.io - Avoid short forms in metrics: "mem" -> "memory", "fs" -> "filesystem" - Use "cpu.usage" in [0,1] scale instead of "cpu.utilization" in percents - Use "cpu.time" in seconds instead of "cpu/cumulative" in nanoseconds Also introduce additional metrics: "network.errors" and "filesystem.usage".
dmitryax
changed the title
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 85.37% 85.40% +0.02%
==========================================
Files 180 180
Lines 9594 9624 +30
==========================================
+ Hits 8191 8219 +28
- Misses 1086 1087 +1
- Partials 317 318 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 20, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Allow instrumentation of newer FastAPI versions Since the introduction of the `_instruments` runtime checks in #475, the FastAPI instrumentation has stopped working for versions >= `0.59.0`. However the current test suite passes even for the latest released version at the moment (`0.67.0`). It seems this isn't related to a limitation in the instrumentation code, but actually because of it being created when `0.58` was the latest version: open-telemetry/opentelemetry-python@7bec76a. * Add changelog entry Co-authored-by: Owais Lone <owais@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update kubeletstats receiver metrics according to open-telemetry/oteps#119 :