Add metrics translations in Signalfx exporter #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metrics translations in Signalfx exporter Introduce translation rules in signalfxexporter to produce metrics in a format that is backward-compatible with SignalFx naming conventions
bogdandrutu
requested changes
Jul 20, 2020
There was a problem hiding this comment.
@dmitryax let's please try to split this PR in ~500 maximum lines changes.
|
@bogdandrutu I split it with the first batch in 678 lines. Splitting it further would not be that easy. Could you please take a look #477 ? |
|
Please rebase |
|
@bogdandrutu I've submitted another PR #489 instead |
codeboten
added a commit
that referenced
this pull request
Nov 23, 2022
This is a port of grpcio-opentracing, and borrows from opencensus-ext-grpc. It adds client and server interceptors that wrap each request in a span and use the new context API to inject/extract the traceparent header to/from gRPC metadata. Co-authored-by: alrex <alrex.boten@gmail.com> Co-authored-by: Mauricio Vásquez <mauricio@kinvolk.io> Co-authored-by: Mario Jonke <mario.jonke@dynatrace.com> Co-authored-by: Daniel González <danielgonzalezlopes@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce optional metric translation in signalfxexporter to produce metrics in a format that is backward-compatible with SignalFx naming conventions