Breaking config change: Update sapm and signalfx to use HttpServerConfig #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
signalsplunk
branch
from
833a54a
to
fa3dd49
Compare
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
===========================================
+ Coverage 71.09% 85.79% +14.69%
===========================================
Files 14 187 +173
Lines 602 9960 +9358
===========================================
+ Hits 428 8545 +8117
- Misses 150 1095 +945
- Partials 24 320 +296
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
This change fixes inconsistencies in component interfaces. Motivation: - Uniformness results in reduction of code that currently has to deal with differences. - Processor.Start is missing and is important for allowing processors to communicate with the Host. What's changed: - Introduced Component interface. - Unified Host interface. - Added a Start function to processors (via Component interface). - Start/Shutdown is now called for Processors from service start/shutdown. - Receivers, Exporters, Processors, Extensions now embed Component interface. - Replaced StartTraceReception/StartMetricsReception by single Start function for receivers. - Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers. Note: before merging this we need to announce the change in Gitter since it breaks existing implementations in contrib (although the fix is easy). Resolves #477 Resolves #262
|
@bogdandrutu codecov is failing (and needs rebase) |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
signalsplunk
branch
from
fa3dd49
to
ab20ec5
Compare
|
@tigrannajaryan PTAL |
rmfitzpatrick
approved these changes
Jul 29, 2020
dmitryax
approved these changes
Jul 29, 2020
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Make propagators conform to spec * do not modify / set an invalid span in the passed context in case a propagator did not manage to extract * in case no context is passed to propagator.extract assume the root context as default so that a new trace is started instead of continung the current active trace in case extraction fails * fix also ot-trace propagator which compared int with str trace/span ids when checking for validity in extract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.