Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skywalking log exporter #4956

Merged
merged 12 commits into from Oct 7, 2021
Merged

Add skywalking log exporter #4956

merged 12 commits into from Oct 7, 2021

Conversation

liqiangz
Copy link
Contributor

@liqiangz liqiangz commented Aug 29, 2021 •
edited

Description: Add skywalking log exporter -- First PR

Link to tracking Issue: apache/skywalking#6209

Testing:

logdata_to_logrecord_test.go

Documentation:
exporter/skywalkingexporter/README.md

@liqiangz liqiangz requested a review from a team as a code owner August 29, 2021 08:15
@project-bot project-bot bot added this to In progress in Collector Aug 29, 2021
This was referenced Aug 29, 2021
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 6, 2021
jpkrohling
jpkrohling reviewed Sep 6, 2021
View reviewed changes
exporter/skywalkingexporter/README.md Outdated Show resolved Hide resolved
exporter/skywalkingexporter/README.md Outdated Show resolved Hide resolved
exporter/skywalkingexporter/README.md Outdated Show resolved Hide resolved
exporter/skywalkingexporter/README.md Outdated Show resolved Hide resolved
exporter/skywalkingexporter/go.mod Outdated Show resolved Hide resolved
exporter/skywalkingexporter/logdata_to_logrecord.go Outdated Show resolved Hide resolved
@jpkrohling jpkrohling removed the Stale label Sep 6, 2021
@liqiangz
Copy link
Contributor Author

liqiangz commented Sep 7, 2021

Updated, Could you please have a review on this. @jpkrohling

@liqiangz liqiangz force-pushed the skywalking branch 2 times, most recently from fb1b592 to ee1b32f Compare September 7, 2021 14:16
Collector automation moved this from In progress to Reviewer approved Sep 8, 2021
@liqiangz
Copy link
Contributor Author

Could you please trigger the ci. @jpkrohling

@liqiangz
Copy link
Contributor Author

@bogdandrutu Updated. Could you please have a review again.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 22, 2021
@bogdandrutu bogdandrutu removed the Stale label Sep 22, 2021
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 30, 2021
@bogdandrutu bogdandrutu removed the Stale label Sep 30, 2021
bogdandrutu
bogdandrutu approved these changes Sep 30, 2021
View reviewed changes
exporter/skywalkingexporter/config_test.go Outdated Show resolved Hide resolved
@liqiangz
Copy link
Contributor Author

liqiangz commented Oct 3, 2021

@bogdandrutu Updated.

@tigrannajaryan
Copy link
Member

@liqiangz please add yourself and anyone else who you believe can help maintain this component to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/CODEOWNERS

tigrannajaryan
tigrannajaryan approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged once codeowners is updated.

@liqiangz
Copy link
Contributor Author

liqiangz commented Oct 5, 2021

@liqiangz please add yourself and anyone else who you believe can help maintain this component to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/CODEOWNERS

@tigrannajaryan Updated.

tigrannajaryan
tigrannajaryan approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@liqiangz
Copy link
Contributor Author

liqiangz commented Oct 7, 2021 •
edited

@jpkrohling @bogdandrutu @tigrannajaryan Could you please trigger the ci again. Some testcase is always in waiting state.

@jpkrohling
Copy link
Member

Restarted.

@tigrannajaryan tigrannajaryan merged commit 0ba52a5 into open-telemetry:main Oct 7, 2021
Collector automation moved this from Reviewer approved to Done Oct 7, 2021
@liqiangz liqiangz mentioned this pull request Oct 10, 2021
Merged
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
@bogdandrutu
nit: fix small comment in pdata (open-telemetry#4956)
e0742c5 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@jpkrohling jpkrohling mentioned this pull request Jun 27, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
No open projects
Collector
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liqiangz @tigrannajaryan @jpkrohling @bogdandrutu