Add an option to force using hostname instead of FQDN in the resource detection processor #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mx-psi
reviewed
Sep 2, 2021
|
Also @hprajapati-splunk you need to sign the CLA so that we can accept your contribution, PTAL at the bot message above! |
…em_source) as per review comment
…stname_sources) as per review comment
… for System detector
dmitryax
reviewed
Sep 3, 2021
dmitryax
reviewed
Sep 13, 2021
|
@dmitryax PTAL also set the "ready-to-merge" label when you are done :) |
hprajapati-splunk
force-pushed
the
main
branch
from
65be6ed
to
a170b2c
Compare
dmitryax
reviewed
Sep 13, 2021
dmitryax
approved these changes
Sep 15, 2021
dmitryax
added
the
ready to merge
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
This includes changes to support optional types: - update sed script to update optional type to oneof - bump proto to 0.15.0 - make genproto - update sum to OptionalType - InstrumentationLibraryMetrics -> ScopeMetrics - InstrumentationLibrarySpans -> ScopeSpans - InstrumentationLibraryLogs -> ScopeLogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an option to force using hostname instead of FQDN in the resource detection processor.
Users can set
hostname_sourcesto["os"]to force the processor to use 'hostname'.This is an opt-in functionality so there are no breaking changes to existing user configurations
Testing:
Existing unit tests have been updated and new unit tests have been added to cover new changes.
Documentation:
README has been updated to show how to use the new custom 'system' configurations