Add client wrapper for MongoDB Atlas support #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmoto
force-pushed
the
mongodbatlas_client_wrapper
branch
2 times, most recently
from
b385ed5
to
87c30de
Compare
jpkrohling
reviewed
Oct 1, 2021
|
Please resolve the conflicts. |
zenmoto
force-pushed
the
mongodbatlas_client_wrapper
branch
3 times, most recently
from
82146e3
to
be380cd
Compare
|
@jpkrohling I think I addressed your concerns- is this looking right to you? |
|
I'll review this again tomorrow morning, sorry for the delay. |
jpkrohling
approved these changes
Oct 13, 2021
bogdandrutu
reviewed
Oct 19, 2021
Adds pagination, error handling, will be extended to manage metric transformation.
MongoDB Atlas wrapper returns errors rather than logging change resource attributes to use conventions modify error handling
zenmoto
force-pushed
the
mongodbatlas_client_wrapper
branch
from
be380cd
to
d09dc67
Compare
|
Rebased on scraperhelper updates from main, will defer adding logging support until a future date after discussing with @bogdandrutu. |
tigrannajaryan
changed the title
tigrannajaryan
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
LGTM.
@bogdandrutu do you have other comments on scraper or good to merge?
| for _, org := range s.client.Organizations(ctx) { | ||
| // Metrics collection starts here | ||
| s.log.Debug("fetch resources for MongoDB Organization", zap.String("org", org.Name)) | ||
| func (s *receiver) poll(ctx context.Context, start string, end string, resolution string) (pdata.Metrics, error) { |
There was a problem hiding this comment.
Nit: large func, difficult to read. Consider refactoring to smaller bit in a future PR.
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds pagination, error handling, will be extended to manage metric
transformation.