Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fluentforwardreceiver): support more complex fluent-bit objects #5676

Merged
merged 3 commits into from
Oct 27, 2021
Merged

feat(fluentforwardreceiver): support more complex fluent-bit objects #5676

merged 3 commits into from
Oct 27, 2021

Conversation

sumo-drosiek
Copy link
Member

Description:

  • use same way to parse attributes and to parse body
  • parse more complex flunet-bit objects as AttributeValue (instead of string)

Link to tracking Issue:

#5674

Testing:

  • unit tests
  • manual functional tests

Documentation:

N/A

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner October 8, 2021 07:27
@sumo-drosiek sumo-drosiek mentioned this pull request Oct 8, 2021
Merged
bogdandrutu
bogdandrutu reviewed Oct 11, 2021
View reviewed changes
receiver/fluentforwardreceiver/conversion.go Outdated
rv := pdata.NewAttributeValueMap()
am := rv.MapVal()
am.EnsureCapacity(len(msi))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange layout, new line or not in both funcs :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be consistent now 😅

@sumo-drosiek
feat(fluentforwardreceiver): support more complex fluent-bit objects
d95e435 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek
refactor(fluentforwardreceiver): minor changes
9b34404 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 21, 2021
@jpkrohling
Copy link
Member

@bogdandrutu, I think this is on you now :-)

@jpkrohling jpkrohling added ready to merge Code review completed; ready to merge by maintainers and removed Stale labels Oct 21, 2021
dmitryax
dmitryax approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

receiver/fluentforwardreceiver/conversion.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 1ac25f9 into open-telemetry:main Oct 27, 2021
@jpkrohling jpkrohling mentioned this pull request Oct 29, 2021
Closed
@pmalek-sumo pmalek-sumo mentioned this pull request Nov 16, 2021
Merged
@sumo-drosiek sumo-drosiek deleted the drosiek-fluent-complex-objects branch January 31, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@anuraaga anuraaga anuraaga approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees

@jpkrohling jpkrohling

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sumo-drosiek @jpkrohling @anuraaga @bogdandrutu @dmitryax