Add /pods endpoint support in kubeletstats receiver to add extra labels #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
kubeletstats-container-id
branch
from
7bd18b0
to
63c82b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
===========================================
+ Coverage 71.09% 86.13% +15.03%
===========================================
Files 14 189 +175
Lines 602 10213 +9611
===========================================
+ Hits 428 8797 +8369
- Misses 150 1093 +943
- Partials 24 323 +299
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
kubeletstats-container-id
branch
3 times, most recently
from
d768350
to
42f934c
Compare
pmcollins
approved these changes
Jul 28, 2020
dmitryax
force-pushed
the
kubeletstats-container-id
branch
from
42f934c
to
9239d77
Compare
This commits adds ability to optionally fetch extra metadata from /pods endpoint in kubeletstats receiver and use that data to set additional labels on metric resource. For now only container.id label is supported
dmitryax
force-pushed
the
kubeletstats-container-id
branch
from
9239d77
to
0e49957
Compare
bogdandrutu
approved these changes
Jul 28, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Fix build links
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
This PR changes the circleci build config to build the project in both go-1.13 and go-1.14 versions. Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commits adds ability to optionally fetch extra metadata from /pods endpoint in kubeletstats receiver and use that data to set additional labels on metric resource. For now only container.id label is supported
Testing: Unit tests and manual testing
Documentation: Additional section in README.md