Signalfx exporter: add filtering option to copy_metrics translation rule #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a filtering option to "copy_metrics" translation rule. It makes it possible to copy datapoints with specific dimensions and skip others.
dmitryax
force-pushed
the
copy-metrics-filter
branch
from
f347113
to
cc84bde
Compare
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 86.19% 86.14% -0.06%
==========================================
Files 191 191
Lines 10362 10376 +14
==========================================
+ Hits 8932 8938 +6
- Misses 1102 1114 +12
+ Partials 328 324 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Jul 29, 2020
bogdandrutu
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a filtering option to "copy_metrics" translation rule. It makes it possible to copy datapoints with specific dimensions and skip others.