Signalfx exporter: Add sum aggregation to metric translations #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sum option to aggregate_metric translation rule
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
- Coverage 86.21% 86.21% -0.01%
==========================================
Files 191 191
Lines 10362 10374 +12
==========================================
+ Hits 8934 8944 +10
- Misses 1101 1102 +1
- Partials 327 328 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 29, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Update processors README.md
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
This avoids any issue with tests that live outside the package in which the code they're testing resides, e.g. api/trace/b3_propagator.go
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Adding a TestBase class which wraps a tracer provider that is configured with a memory span exporter. This class inherits from unitest.TestCase, hence other test classes can inherit from it to get access to the underlying memory span exporter and tracer provider. Adding a mock propagator that could be used for testing propagation in different packages. It was implemented in the opentracing-shim and this commit moves it to a generic place. Adding disable_session(), which can be used to disable the instrumentation on a single requests' session object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add "sum" aggregation method to "aggregate_metric" translation rule in signalfx exporter.