Update memcached receiver #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry-collector-contrib into update-memcached-receiver
…IQ/opentelemetry-collector-contrib into update-memcached-receiver
Normalizesums
…y-collector-contrib into update-memcached-receiver
djaglowski
reviewed
Nov 11, 2021
djaglowski
reviewed
Nov 11, 2021
receiver/memcachedreceiver/testdata/expected_metrics/test_scraper/exepected.json
Outdated
Show resolved
Hide resolved
djaglowski
reviewed
Nov 11, 2021
djaglowski
reviewed
Nov 12, 2021
djaglowski
reviewed
Nov 15, 2021
djaglowski
reviewed
Nov 16, 2021
djaglowski
approved these changes
Nov 16, 2021
djaglowski
added
the
ready to merge
junhaoyu-aws
added a commit
to junhaoyu-aws/opentelemetry-collector-contrib
that referenced
this pull request
Aug 10, 2022
…the Break Change open-telemetry#5839 in upstream Fixed return types for s3mapprovider - keep consistency according to the Break Change open-telemetry#5839 in upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added additional metrics to the memcached receiver.
Testing:
Updated Scraper test to better reflect the new metrics
Also, created a mock client to enable better validation.