Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadogexporter] [Breaking change] Make distributions the default histogram export option #5885

Merged

Conversation

KSerrania
Copy link
Contributor

@KSerrania KSerrania commented Oct 25, 2021

Description:

Changes the default histogram export option to distributions + removes count and sum metrics by default (breaking change: by default, only count and sum metrics were sent for histograms).
Refactors the metric translator unit tests to cover all valid histogram cases.

Link to tracking Issue: n/a

Testing: Amended & updated unit tests.

Documentation: Inline docs & example config files.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention somewhere (PR title?) that this is a breaking change, so that it gets reflected properly on the changelog

exporter/datadogexporter/factory.go Show resolved Hide resolved
@KSerrania KSerrania changed the title [datadogexporter] Make distributions the default histogram export option [datadogexporter] [Breaking change] Make distributions the default histogram export option Oct 25, 2021
@KSerrania KSerrania marked this pull request as ready for review October 25, 2021 10:57
@KSerrania KSerrania requested a review from a team as a code owner October 25, 2021 10:57
@mx-psi mx-psi added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Oct 26, 2021
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we have #5925

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Oct 27, 2021
@bogdandrutu bogdandrutu merged commit 059b982 into open-telemetry:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants