5180 enable awscontainerinsightreceiver #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
reviewed
Oct 27, 2021
Aneurysm9
previously approved these changes
Oct 28, 2021
jefchien
reviewed
Oct 28, 2021
bogdandrutu
requested changes
Oct 28, 2021
There was a problem hiding this comment.
Based on the author comment:
I think the tests were failing because they're not setup properly but since the purpose of this PR is to enable the receiver and not necessarily validate that it works properly, I believe we can follow up with that
This is not how the project works sorry.
Aneurysm9
dismissed
their stale review
Requires explanation of skipped test steps.
bogdandrutu
approved these changes
Oct 28, 2021
codeboten
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
@Aneurysm9 can you approve on behalf of codeowners for this receiver.
Aneurysm9
approved these changes
Oct 28, 2021
alolita
approved these changes
Oct 28, 2021
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Signed-off-by: Bogdan <bogdandrutu@gmail.com> Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Customer noticed config value
awscontainerinsightreceivernot being recognized.Enabling awscontainerinsightreceiver for otel-collector-contrib
Link to tracking Issue: #5180
Testing:
reproduced error by building otel contrib locally with master
and then rebuilt with changes and
awscontainerinsightreceiverwas now recognizedDocumentation: