Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus Receiver test for label_name_length_limit configuration #6362

Merged

Conversation

mustafain117
Copy link
Contributor

@mustafain117 mustafain117 commented Nov 17, 2021

Description:
This PR depends on #6150 , commit 68e77b6 adds the test for label_name_length_limit
Adds TestLabelNameLimitConfig to test label_name_length_limit configuration for Prometheus receiver

TestLabelNameLimitConfig:
Sets the label_name_length_limit for Prometheus receiver
Tests the following two scenarios:

  • Positive test case: Prometheus receiver scrapes metrics which are within the label_name_length_limit
    • Assert scrape is successful
  • Negative test case: Prometheus receiver scrapes metrics which exceed label_name_length_limit
    • Assert scrape is unsuccessful

Link to tracking Issue:
PR 2/3 for #5997 . Following PR will add test for label_value_length_limit

@alolita
Copy link
Member

alolita commented Nov 17, 2021

@dashpole @vishiy can you provide a review? Then we should be ready to merge. Ty!!

@alolita alolita added comp: receiver Receiver comp:prometheus Prometheus related issues labels Nov 17, 2021
@alolita alolita added the ready to merge Code review completed; ready to merge by maintainers label Nov 22, 2021
@codeboten codeboten merged commit b8e2267 into open-telemetry:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:prometheus Prometheus related issues comp: receiver Receiver ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants