Add Prometheus Receiver tests for honor_labels configuration #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Nov 19, 2021
|
@codeboten Done! |
codeboten
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Tests look good to me, pinging @Aneurysm9 as a codeowner for a review.
dashpole
approved these changes
Nov 23, 2021
dashpole
reviewed
Nov 23, 2021
| func verifyHonorLabelsTrue(t *testing.T, td *testData, rms []*pdata.ResourceMetrics) { | ||
| //Test for honor_labels: true is skipped. Currently, the Prometheus receiver is unable to support this config | ||
| //See: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/5757 | ||
| t.Skip("skipping test for honor_labels true configuration") |
There was a problem hiding this comment.
Skipped tests tend to drift in my experience. I'd prefer to omit the tests, and leave a TODO with a link to the issue to add them.
There was a problem hiding this comment.
Since we've got an implementation that should work if the appender were able to handle this case I'd like to get this into the history so we can easily resurrect it. Because we squash PRs to a single commit that means that we'd need to land this and then remove it in a subsequent PR. I'm fine with leaving it in with a skip but we can follow up to remove this if you think it needs to go.
6 tasks
Aneurysm9
approved these changes
Nov 29, 2021
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2021
…lemetry#6369) * refactor existing external labels test * Add test for label_limit configuration * shutdown mock prometheus http test server within testHelper * fix spelling * fix lint error * rename testHelper to testMetricsReceiver * fix: lint issue in metrics_receiver_helper_test.go * Add Prometheus receiver test for honor_labels configuration * update TestHonorLabelsFalseConfig to use testComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR depends on #6150, the latest commit in this PR is relevant to the honor_labels configuration test
Adds
TestHonorLabelsFalseConfigto testhonor_labels : falseconfigurationAdds
TestHonorLabelsTrueConfigto testhonor_labels : trueconfigurationDetails:
Both tests use the following test data:
TestHonorLabelsFalseConfig:Sets
honor_labels : falsefor the scrape configurationValidates that the label conflicts are resolved by prefixing job and instance labels with "exported_" for the
test_gauge0metricTestHonorLabelsTrueConfig:Sets
honor_labels : truefor the scrape configurationValidates that the label conflicts are resolved by keeping job and instance label values from the scraped data
Link to tracking Issue:
Closes #5995