Add Prometheus Receiver tests to run OpenMetrics test cases #6409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
Nov 23, 2021
receiver/prometheusreceiver/metrics_receiver_open_metrics_test.go
Outdated
Show resolved
Hide resolved
@dashpole My initial approach was to pull the test data within these tests directly from the openmetrics repo but that meant the tests would be dependent on GitHub availability. Will discuss this in the Prometheus WG meeting and perhaps we can open a follow up issue if we want to keep the tests in sync. |
dashpole
approved these changes
Nov 23, 2021
Aneurysm9
approved these changes
Nov 24, 2021
alolita
added
comp:prometheus
|
@codeboten can you please merge? We are blocked on other PRs dependent on this one :-) Ty! |
codeboten
reviewed
Nov 24, 2021
Comment on lines
+32
to
+52
| "bad_clashing_names_0": {}, "bad_clashing_names_1": {}, "bad_clashing_names_2": {}, | ||
| "bad_counter_values_0": {}, "bad_counter_values_1": {}, "bad_counter_values_2": {}, | ||
| "bad_counter_values_3": {}, "bad_counter_values_5": {}, "bad_counter_values_6": {}, | ||
| "bad_counter_values_10": {}, "bad_counter_values_11": {}, "bad_counter_values_12": {}, | ||
| "bad_counter_values_13": {}, "bad_counter_values_14": {}, "bad_counter_values_15": {}, | ||
| "bad_counter_values_16": {}, "bad_counter_values_17": {}, "bad_counter_values_18": {}, | ||
| "bad_counter_values_19": {}, "bad_exemplars_on_unallowed_samples_2": {}, "bad_exemplar_timestamp_0": {}, | ||
| "bad_exemplar_timestamp_1": {}, "bad_exemplar_timestamp_2": {}, "bad_grouping_or_ordering_0": {}, | ||
| "bad_grouping_or_ordering_2": {}, "bad_grouping_or_ordering_3": {}, "bad_grouping_or_ordering_4": {}, | ||
| "bad_grouping_or_ordering_5": {}, "bad_grouping_or_ordering_6": {}, "bad_grouping_or_ordering_7": {}, | ||
| "bad_grouping_or_ordering_8": {}, "bad_grouping_or_ordering_9": {}, "bad_grouping_or_ordering_10": {}, | ||
| "bad_histograms_0": {}, "bad_histograms_1": {}, "bad_histograms_2": {}, "bad_histograms_3": {}, | ||
| "bad_histograms_6": {}, "bad_histograms_7": {}, "bad_histograms_8": {}, | ||
| "bad_info_and_stateset_values_0": {}, "bad_info_and_stateset_values_1": {}, "bad_metadata_in_wrong_place_0": {}, | ||
| "bad_metadata_in_wrong_place_1": {}, "bad_metadata_in_wrong_place_2": {}, | ||
| "bad_missing_or_invalid_labels_for_a_type_1": {}, "bad_missing_or_invalid_labels_for_a_type_3": {}, | ||
| "bad_missing_or_invalid_labels_for_a_type_4": {}, "bad_missing_or_invalid_labels_for_a_type_6": {}, | ||
| "bad_missing_or_invalid_labels_for_a_type_7": {}, "bad_repeated_metadata_0": {}, | ||
| "bad_repeated_metadata_1": {}, "bad_repeated_metadata_3": {}, "bad_stateset_info_values_0": {}, | ||
| "bad_stateset_info_values_1": {}, "bad_stateset_info_values_2": {}, "bad_stateset_info_values_3": {}, | ||
| "bad_timestamp_4": {}, "bad_timestamp_5": {}, "bad_timestamp_7": {}, "bad_unit_6": {}, "bad_unit_7": {}, |
There was a problem hiding this comment.
why pull all these tests in if we're skipping them?
There was a problem hiding this comment.
The idea was to keep track of the open metrics tests that aren't currently supported by the receiver.
This was referenced Nov 24, 2021
Created #6439. |
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2021
…emetry#6409) * Add Prometheus receiver test to run OpenMetrics test cases * fix: resolved gosec lint issue * fix error handling in getTestCase * remove http requests in tests by copying openmetrics data into testdata * only skip failing openmetrics tests using a deny-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In order to verify that the Prometheus Receiver is functioning as expected for transforming OpenMetrics exposition to OTLP format, this PR adds two tests to run positive and negative test cases form the OpenMetrics repository (https://github.com/OpenObservability/OpenMetrics/tree/main/tests/testdata/parsers).
TestOpenMetricsPositivetest:TestOpenMetricsNegativetest:Link to tracking Issue:
Closes #6106