[extension/oauth2clientauth] Use new client auth helpers #7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jpkrohling
force-pushed
the
jpkroehling/core/issue4557
branch
2 times, most recently
from
bc866b5
to
449a49a
Compare
jpkrohling
requested review from
a team,
djaglowski,
pmm-sumo,
dashpole,
jmacd,
dmitryax,
Aneurysm9,
anuraaga,
bogdandrutu,
punya,
mx-psi,
jsuereth,
arminru and
alolita
as code owners
jpkrohling
force-pushed
the
jpkroehling/core/issue4557
branch
from
449a49a
to
30ad379
Compare
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkroehling/core/issue4557
branch
from
30ad379
to
8a0958b
Compare
pmm-sumo
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once open-telemetry/opentelemetry-collector#4837 gets merged, this change will make use of the new helper functions.
This PR also serves to demonstrate the benefits of the default client auth implementation.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de