Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/clickhouse] Implement consume log logic #8028

Merged
merged 3 commits into from
Mar 8, 2022
Merged

[exporter/clickhouse] Implement consume log logic #8028

merged 3 commits into from
Mar 8, 2022

Conversation

hanjm
Copy link
Member

@hanjm hanjm commented Feb 19, 2022 •
edited
Loading

Description:

This is the second PR to implement clickhouseexporter.
First PR: #6907

Plan:

  • Add e2e test.
  • Add more index.
  • Support Distributed table.
  • Support consume traces.
  • Add benchmark.

Link to tracking Issue:
#2320
Testing:

  1. Unit test.
  2. Test with docker-compose (in example dir).

Documentation:

@hanjm hanjm requested review from a team and dmitryax as code owners February 19, 2022 12:01
@project-bot project-bot bot added this to In progress in Collector Feb 19, 2022
@dmitryax
Copy link
Member

Please rebase to resolve conflicts

@hanjm
Copy link
Member Author

hanjm commented Feb 26, 2022 •
edited
Loading

Rebase done again. Thank you. @dmitryax

@hanjm hanjm requested a review from dmitryax March 1, 2022 09:27
@hanjm hanjm mentioned this pull request Mar 3, 2022
Merged
12 tasks
dmitryax
dmitryax approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Collector automation moved this from In progress to Reviewer approved Mar 4, 2022
@hanjm
Copy link
Member Author

hanjm commented Mar 4, 2022 •
edited
Loading

@dmitryax Some test flaky, what could I do?

Another excited message is the latest grafana-clickhouse-datasource support query clickhouse logs in explore UI. grafana/clickhouse-datasource#23

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Mar 4, 2022
@hanjm
Copy link
Member Author

hanjm commented Mar 7, 2022

hi @dmitryax @mx-psi , rebase done and all ci checkers passed.

@dmitryax
Copy link
Member

dmitryax commented Mar 7, 2022

@hanjm thanks. One of the @open-telemetry/collector-contrib-maintainer can merge it

@hanjm
[exporter/clickhouse] Implement consume log logic
6af3684 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm
make table name configurable
e6d79ee 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm
make field name align to the specification
a282220 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@codeboten codeboten merged commit 8de9d21 into open-telemetry:main Mar 8, 2022
foxlegend pushed a commit to foxlegend/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2022
@hanjm
[exporter/clickhouse] Implement consume log logic (open-telemetry#8028)
b59221b 
* [exporter/clickhouse] Implement consume log logic

Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm hanjm mentioned this pull request Jul 24, 2022
Merged
@hanjm hanjm mentioned this pull request Aug 7, 2022
Merged
@hanjm hanjm mentioned this pull request Aug 20, 2022
Merged
@hanjm hanjm mentioned this pull request Sep 29, 2022
Merged
@hanjm hanjm mentioned this pull request Nov 6, 2022
Closed
@hanjm hanjm mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees

@mx-psi mx-psi

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hanjm @dmitryax @codeboten @mx-psi