Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signalfx exporter: add translation rule to drop redundant metrics #809

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Aug 25, 2020

And remove intermediate metrics used to calculate disk.utilization

@dmitryax dmitryax requested a review from a team as a code owner August 25, 2020 03:15
@dmitryax dmitryax force-pushed the sfxexporter-drop-metric-action branch from 1702d69 to 4a9e363 Compare August 25, 2020 04:02
@dmitryax dmitryax force-pushed the sfxexporter-drop-metric-action branch from 4a9e363 to 62b9193 Compare August 25, 2020 04:58
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #809 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files         233      233              
  Lines       12353    12364      +11     
==========================================
+ Hits        10878    10887       +9     
- Misses       1119     1120       +1     
- Partials      356      357       +1     
Flag Coverage Δ
#integration 72.00% <ø> (ø)
#unit 87.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xporter/signalfxexporter/translation/translator.go 96.55% <100.00%> (+0.12%) ⬆️
receiver/carbonreceiver/transport/tcp_server.go 65.71% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cde40...62b9193. Read the comment docs.

@bogdandrutu bogdandrutu merged commit d0fcf9c into open-telemetry:master Aug 25, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
opentelemetry-test was not listed as a test dependency in the asgi instrumentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants