[receiver/windowsperfcountersreceiver] Update how metrics are established #8376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrod1598
changed the title
djaglowski
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Ideally we would extract the metric metadata structs from mdatagen so that this component is not just approximating the functionality. However, at a glance this appears not to be very straightforward. I think we should at least open a tracking issue to capture the intention though.
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go
Outdated
Show resolved
Hide resolved
Mrod1598
force-pushed
the
windowsperfcounter-rework
branch
from
d0d278d
to
7ecedb6
Compare
djaglowski
reviewed
Mar 15, 2022
djaglowski
reviewed
Mar 16, 2022
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go
Outdated
Show resolved
Hide resolved
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go
Outdated
Show resolved
Hide resolved
djaglowski
reviewed
Mar 18, 2022
djaglowski
approved these changes
Mar 18, 2022
jpkrohling
previously requested changes
Mar 18, 2022
CHANGELOG.md
Outdated
| @@ -29,6 +29,7 @@ | |||
|
|
|||
| ### 🛑 Breaking changes 🛑 | |||
|
|
|||
| - `windowsperfcountersreceiver`: Added metrics configuration (#8376) | |||
There was a problem hiding this comment.
Looks like I can't change this PR, so I can't fix this for you, but this now needs to be moved up to the "unreleased" section.
|
To the next reviewer: feel free to dismiss my review once the changelog is fixed. |
foxlegend
pushed a commit
to foxlegend/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2022
…shed (open-telemetry#8376) * Add ability to define metrics * Update tests * Update Readme * Add attributes to readme * Update values for metric config in readme * Update changelog * Fix lint * Fix misspelling * Force rerun * Rename keys in Counter config * Restructure metrics into map * Remove Value type & Add defaults * Remove extra test case * Fix tests * Add handling for no metrics defined * Add no metric definition test * Rework Readme wording * Add no metrics factory test * Add no Metrics config test * Add no metric specified test * Fix test * Add More Tests * Add ignoreValues option * Fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated the receiver to enable metrics configuration. Additionally, once the
mdatagenpackage makes the applicable structs public, this receiver will be updated to use those.Link to tracking Issue:
#8259
Testing:
Along side the updated config options, additional tests were added to test the new config options. Also, updated the the scraper tests to test the different metric formats.
Documentation:
Updated the documentation to use the new config options and describe where to use them.