Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core dependency and adopt code to the API changes #8791

Merged
merged 1 commit into from Mar 23, 2022

Conversation

dmitryax
Copy link
Member

Remove usage of deprecated API:

  • pdata.AttributeMap
  • pdata.NewAttributeMap
  • pdata.NewAttributeMapFromMap
  • pdata.AttributeValueSlice
  • pdata.NewAttributeValueSlice

Remove usage of deleted pdata.InternalRep

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 23, 2022
@dmitryax dmitryax force-pushed the upgrade-core branch 2 times, most recently from 66a6463 to 92ce215 Compare March 23, 2022 01:40
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase now that #8807 is merged

@dmitryax dmitryax force-pushed the upgrade-core branch 2 times, most recently from 726e69a to 76c15ea Compare March 23, 2022 05:16
@dmitryax
Copy link
Member Author

@codeboten done

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! as i was reviewing another pr got merged and there's a new conflict to resolve

@dmitryax dmitryax force-pushed the upgrade-core branch 3 times, most recently from 8f22ec4 to 89c2f4c Compare March 23, 2022 19:28
Remove usage of deprecated API:
- `pdata.AttributeMap`
- `pdata.NewAttributeMap`
- `pdata.NewAttributeMapFromMap`
- `pdata.AttributeValueSlice`
- `pdata.NewAttributeValueSlice`

Remove usage of deleted `pdata.InternalRep`
@dmitryax
Copy link
Member Author

dmitryax commented Mar 23, 2022

@codeboten no problem. I rebased and got the tests passing. PTAL

@codeboten codeboten merged commit ac8d866 into open-telemetry:main Mar 23, 2022
@dmitryax dmitryax deleted the upgrade-core branch March 24, 2022 00:49
foxlegend pushed a commit to foxlegend/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2022
Remove usage of deprecated API:
- `pdata.AttributeMap`
- `pdata.NewAttributeMap`
- `pdata.NewAttributeMapFromMap`
- `pdata.AttributeValueSlice`
- `pdata.NewAttributeValueSlice`

Remove usage of deleted `pdata.InternalRep`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants