[extension/jaegerremotesampling] Tie in the strategy storages #8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
changed the title
|
@dashpole, once this is reviewed, I'll rebase and take care of the conflicts. |
dashpole
reviewed
Mar 24, 2022
| require.NoError(t, e.Start(context.Background(), componenttest.NewNopHost())) | ||
|
|
||
| // test and verify | ||
| assert.NoError(t, e.Shutdown(context.Background())) | ||
| } | ||
|
|
||
| func TestFailedToStartHTTPServer(t *testing.T) { |
There was a problem hiding this comment.
Is this test just not needed anymore?
There was a problem hiding this comment.
Kind of: previously, I had the ability to provide an HTTP server, making it trivial to test a failure scenario. Now, I moved the entire initialization logic to the start function, so that an HTTP server is created there. Failure testing is now more complicated.
pmm-sumo
reviewed
Mar 25, 2022
jpkrohling
force-pushed
the
jpkrohling/issue6695
branch
from
d62885e
to
dbe3d57
Compare
|
This is ready for another review round. |
|
@dashpole, would you mind reviewing this once again? |
jpkrohling
force-pushed
the
jpkrohling/issue6695
branch
from
dbe3d57
to
5a63410
Compare
pmm-sumo
approved these changes
Mar 31, 2022
jpkrohling
force-pushed
the
jpkrohling/issue6695
branch
from
5a63410
to
1660d6e
Compare
This change adds support for the strategy stores, previously referenced as client config managers. This implements both the local file strategy store and the remote (gRPC) store. Fixes #6695 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/issue6695
branch
from
1660d6e
to
a22e412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the strategy stores, previously referenced as client config managers.
This implements both the local file strategy store and the remote (gRPC) store.
Fixes #6695
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de