[receiver/hostmetrics/process_scraper] Rename metadata conflicting wi… #8979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the metrics package name Signed-off-by: Idowu Emehinola <hydeenoble39@gmail.com>
|
|
codeboten
reviewed
Apr 6, 2022
There was a problem hiding this comment.
Thanks for the fix @hydeenoble, please sign the CLA so we can get this reviewed and merged!
Done! @codeboten |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Apr 21, 2022
codeboten
approved these changes
Apr 22, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…th the metrics package name (open-telemetry#8979) Signed-off-by: Idowu Emehinola <hydeenoble39@gmail.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th the metrics package name
Signed-off-by: Idowu Emehinola hydeenoble39@gmail.com
Description:
The local variable name
metadataconflicts with the generated package name and makes this less readable. I renamedmetadataconflicting with the metrics package name todataLink to tracking Issue: Closes #8815
Testing:
Documentation: