feat(routingprocessor): add option to drop resource attribute used for routing #8990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
force-pushed
the
routingprocessor-add-option-to-drop-routing-attribute
branch
from
19372c0
to
34f0e08
Compare
|
I'll take a look soon, but I might have the chance to look at it only next week (Tue perhaps). |
jpkrohling
approved these changes
Apr 8, 2022
| @@ -22,6 +22,7 @@ The following settings can be optionally configured: | |||
| - `attribute_source` defines where to look for the attribute in `from_attribute`. The allowed values are: | |||
| - `context` (the default) - to search the [context][context_docs], which includes HTTP headers | |||
| - `resource` - to search the resource attributes. | |||
| - `drop_resource_routing_attribute` - controls whether to remove the resource attribute used for routing. This is only relevant if AttributeSource is set to resource. | |||
There was a problem hiding this comment.
It's a bit verbose for my taste, but I can't come up with a better name :-)
| assert.False(t, ok, "routing attribute should be dropped") | ||
| v, ok := attrs.Get("attr") | ||
| assert.True(t, ok, "non routing attributes shouldn't be dropped") | ||
| assert.Equal(t, "acme", v.StringVal()) |
| assert.False(t, ok, "routing attribute should be dropped") | ||
| v, ok := attrs.Get("attr") | ||
| assert.True(t, ok, "non routing attributes shouldn't be dropped") | ||
| assert.Equal(t, "acme", v.StringVal()) |
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
pmalek-sumo
force-pushed
the
routingprocessor-add-option-to-drop-routing-attribute
branch
from
6f68233
to
4f3acce
Compare
jpkrohling
approved these changes
Apr 8, 2022
|
Unrelated test failure: |
sumo-drosiek
deleted the
routingprocessor-add-option-to-drop-routing-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: add an option to drop the attribute used for routing
Link to tracking Issue: #7407
Testing: Added UTs
Documentation: Added change in processor's README.