[exporter/lokiexporter] Fix lokiexporter example config #9066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
otaviocarvalho
commented
Apr 4, 2022
| @@ -16,7 +16,6 @@ processors: | |||
| # information, see | |||
| # https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/README.md | |||
| memory_limiter: | |||
| ballast_size_mib: 683 | |||
There was a problem hiding this comment.
This deprecated parameter was also preventing the otel container to execute, please let me know if there is a better option than removing it.
There was a problem hiding this comment.
The recommendation is to use the ballast extension
otaviocarvalho
force-pushed
the
fix-lokiexporter-example-config
branch
from
8c9f176
to
fd92340
Compare
codeboten
reviewed
Apr 4, 2022
| @@ -16,7 +16,6 @@ processors: | |||
| # information, see | |||
| # https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/memorylimiterprocessor/README.md | |||
| memory_limiter: | |||
| ballast_size_mib: 683 | |||
There was a problem hiding this comment.
The recommendation is to use the ballast extension
codeboten
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base example otel-collector-config.yml file for the lokiexporter sets resources (plural form) while the mapstructure is resource (singular form).
This PR fixes the sample adjusting it to the actual resource format. Another option would be to make the mapstructure plural, but that would imply a contract (breaking) change.