[extension/filestorage] use correct bbolt options for compaction #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm-sumo
force-pushed
the
fix/filestorageextension/bbolt-options
branch
from
63b5d47
to
f1d1829
Compare
pmm-sumo
reviewed
Apr 11, 2022
| [v0.0.1]: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.0.1 |
There was a problem hiding this comment.
Hmm, saw the same thing in some other PR, realized there seems to be a trailing space added by #8548
There was a problem hiding this comment.
I'm not blocking this PR because of this :-) Merging.
pmm-sumo
approved these changes
Apr 11, 2022
|
The tests are passing and we agreed on this change in the previous PR, so I'm attaching ready to merge tag |
pmm-sumo
added
the
ready to merge
|
👍 LGTM. Was waiting for tests to pass before approving but didn't circle back soon enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We changed the bbolt options for opening the db on client creation in #9004 but forgot to change them for compaction as well.
Link to tracking Issue: N/A
Testing: Existing tests are good enough. This change only affects performance in particular circumstances. See #9004 and the linked issue for a more detailed discussion.
Documentation: N/A