Fix key TTL to fix flaky test #9269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please add the "skip changelog" tag? This change is minor and test-only so I doubt it needs a changelog entry. |
dmitryax
approved these changes
Apr 14, 2022
|
Load tests restarted. |
codeboten
approved these changes
Apr 18, 2022
vladracula
referenced
this pull request
in SabreOSS/opentelemetry-collector-contrib
May 2, 2022
(cherry picked from commit 7ad1e16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #9259
There was a typo in the test where I forgot to add a
* time.Secondafter the TTL value, so the key's TTL was 60 nanoseconds instead of 60 seconds. The build environment must be slow enough, but not the local environments. Produced locally by running it through the debugger which slowed down the execution time enough to see what was going on.