[processor/tailsampling] Cleanly tear down test #9283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
dmitryax
approved these changes
Apr 15, 2022
vladracula
referenced
this pull request
in SabreOSS/opentelemetry-collector-contrib
May 2, 2022
* [processor/tailsampling] Cleanly tear down test Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Move goleaks to main require section Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> (cherry picked from commit ba5cb7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the factory test to properly initialize and shutdown the processor, so that initialized go routines are properly cleaned. It also adds goleaks to detect leaks of go routines.
Attempts to fix #9126
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de