Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/simpleprometheus] update example to use Meter directly #9364

Merged
merged 2 commits into from
Jun 3, 2022
Merged

[receiver/simpleprometheus] update example to use Meter directly #9364

merged 2 commits into from
Jun 3, 2022

Conversation

codeboten
Copy link
Contributor

This is a follow up to #9337.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 19, 2022
@codeboten codeboten requested a review from a team as a code owner April 19, 2022 15:17
@codeboten codeboten requested a review from dmitryax April 19, 2022 15:17
@codeboten codeboten changed the title [simpleprometheus] update example to use Meter directly [receiver/simpleprometheus] update example to use Meter directly Apr 19, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 18, 2022
codeboten
codeboten commented May 31, 2022
View reviewed changes
Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu PTAL

@codeboten codeboten removed the Stale label May 31, 2022
@codeboten codeboten merged commit 3fc0a28 into open-telemetry:main Jun 3, 2022
@codeboten codeboten deleted the codeboten/minor-fix branch June 3, 2022 17:49
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
@kentquirk
[receiver/simpleprometheus] update example to use Meter directly (ope…
07f526c 
…n-telemetry#9364)

* [simpleprometheus] update example to use Meter directly

This is a follow up to open-telemetry#9337.

* update example to avoid using global
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@djaglowski djaglowski

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codeboten @bogdandrutu @djaglowski